Delay displaying discovered devices until DNS-SD discovery completes - #455
Draft
SinghCod3r wants to merge 1 commit into
Draft
Delay displaying discovered devices until DNS-SD discovery completes#455SinghCod3r wants to merge 1 commit into
SinghCod3r wants to merge 1 commit into
Conversation
Buffer discovered devices until DNS-SD resolution finishes so the UI is updated only once. This avoids the brief appearance and removal of legacy USB printers when an IPP-over-USB device is discovered. Signed-off-by: SinghCod3r <ayushsinghceee@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a printer supports IPP-over-USB, device discovery currently happens in
multiple stages:
As a result, the legacy USB device briefly appears in the list before being
suppressed in favor of the IPP-over-USB device, causing a noticeable UI
flicker.
Solution
Buffer discovered devices until discovery has completed.
Instead of updating the UI after each discovery phase, this change collects
local devices, network devices, and resolved DNS-SD devices before calling
add_devices().This allows duplicate suppression to operate on the complete device set before
anything is inserted into the TreeView, eliminating the temporary USB entry.
Additional changes
usb_SERTXT record.Testing
Tested manually with an IPP-over-USB printer.